| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/2] xfs: suppress spurious uninitialised var warning in xfs_bmapi() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 19 Jan 2010 04:22:40 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1263861711-13900-2-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1263861711-13900-1-git-send-email-david@xxxxxxxxxxxxx> <1263861711-13900-2-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Tue, Jan 19, 2010 at 11:41:50AM +1100, Dave Chinner wrote: > Initialise the xfs_bmalloca_t structure to zero to avoid uninitialised > variable warnings. This is done by zeroing the arg structure rather than > using the uninitialised_var() trick so we know for certain that the > structure is correctly initialised as xfs_bmapi is a very complex > function and it is difficult to prove warnings are spurious. > > Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/7] xfsprogs: fix some trivial warnings in xfs_db, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/2] xfs: rearrange xfs_mod_sb() to avoid array subscript warning, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/2] xfs: suppress spurious uninitialised var warning in xfs_bmapi(), Dave Chinner |
| Next by Thread: | acl build failure on x86_64, Jon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |