| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsteststs: get fsstress DIO working on non-xfs filesystems |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 19 Jan 2010 12:08:03 +1100 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <4B54C8AB.6080607@xxxxxxxxxxx> |
| References: | <4B54C8AB.6080607@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Mon, Jan 18, 2010 at 02:46:35PM -0600, Eric Sandeen wrote: > Pretty sure all DIO IO fails in fsstress today since XFS_IOC_DIOINFO > fails. If so, rather than just bailing out on the op, assign > some sane default DIO parameters. > > This falls down for 4k sector devices but not really sure how to get > the underlying sector size easily from here; I think we can live > with this for now. ioctl(fd, BLKSSZGET, ...) perhaps? And then if that fails, just hard code it? > hch suggested moving XFS_IOC_DIOINFO up higher in the vfs, that's > probably a good idea in the long run. Yeah, that makes sense to do. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] mkfs: don't warn about topology when mkfsing a file, Dave Chinner |
|---|---|
| Next by Date: | acl build failure on x86_64, Jon |
| Previous by Thread: | [PATCH] xfsteststs: get fsstress DIO working on non-xfs filesystems, Eric Sandeen |
| Next by Thread: | Re: [PATCH] xfsteststs: get fsstress DIO working on non-xfs filesystems, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |