| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: Clean up build output |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 17 Jan 2010 06:59:05 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1263384325-15300-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1263384325-15300-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Wed, Jan 13, 2010 at 11:05:25PM +1100, Dave Chinner wrote: > While doing this, remove explicit target-per-file rules in the > subdirectories being built and replace them with target based rules > using the buildrules hooks for doing this. This results in the > makefiles being simpler, smaller and more consistent. I agree, but it's also rather unrelated to the output.. A side effect of that rule cleanup seems that we now link all binaries against all libraries used in a subdirectory. I don't think it's a problem, but it's at least worth mentioning. I'd really prefer if you could split this into two patches, but if that's too much work consider this reviewed anyway: Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfsprogs: Make the compile output cleaner V2, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] xfsdump: Clean up build output, Christoph Hellwig |
| Previous by Thread: | [PATCH] xfstests: Clean up build output, Dave Chinner |
| Next by Thread: | [PATCH] xfsprogs: fix build with latest glibc headers, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |