| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsprogs: Make the compile output cleaner V2 |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 17 Jan 2010 06:55:15 -0500 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20100114101128.GX17483@xxxxxxxxxxxxxxxx> |
| References: | <1263377007-4500-1-git-send-email-david@xxxxxxxxxxxxx> <20100113220814.GA17310@xxxxxxxxxxxxx> <20100113223001.GR17483@xxxxxxxxxxxxxxxx> <20100114065123.GA32559@xxxxxxxxxxxxx> <20100114101128.GX17483@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Thu, Jan 14, 2010 at 09:11:28PM +1100, Dave Chinner wrote: > It seems completely spurious to me - normal practice is to blow away > the config on a distclean, not a plain clean. And seeing as the > patch is about removing noise during the normal build, I figured > this qualified as a bug causing noise. > > I can separate it out into another patch, but I'd really prefer that > make clean doesn't result in running configure again. Especially > considering the build dependencies are very broken so the only way > to guarantee a build catches all changes is to do 'make clean; > make'. Looking at various other packages it seems like configure output usually survives make clean indeed. With that I agree with the change, but it really should be a separate patch. Reviewed-by: Christoph Hellwig <hch@xxxxxx> For this one without that change, and I'll also approve the make clean change when you send it. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/9] xfsprogs: Fix miscellaneous warnings in libxfs, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] xfstests: Clean up build output, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfsprogs: Make the compile output cleaner V2, Dave Chinner |
| Next by Thread: | RE: [PATCH] xfsprogs: Make the compile output cleaner V2, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |