| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/9] xfsprogs: fix missing error check in xfs_rtfree_range in libxfs |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 17 Jan 2010 06:52:12 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1263463752-5052-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1263463752-5052-1-git-send-email-david@xxxxxxxxxxxxx> <1263463752-5052-4-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Thu, Jan 14, 2010 at 09:09:06PM +1100, Dave Chinner wrote: > When xfs_rtfind_forw() returns an error, the block is returned > uninitialised. xfs_rtfree_range() is not checking the error return, > so could be using an uninitialised block number for modifying bitmap > summary info. Looks good, (actually a merge of the kernel side fix that just went in) Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 7/9] xfsprogs: fix print format warnings in xfs_io, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/9] xfsprogs: Fix miscellaneous warnings in libxfs, Christoph Hellwig |
| Previous by Thread: | [PATCH 3/9] xfsprogs: fix missing error check in xfs_rtfree_range in libxfs, Dave Chinner |
| Next by Thread: | [PATCH 8/9] xfsprogs: fix sign warning in mkfs directory code, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |