| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: make several more functions static |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 20 Nov 2009 17:37:20 +1100 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <4B0569A0.10405@xxxxxxxxxxx> |
| References: | <4B0569A0.10405@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Thu, Nov 19, 2009 at 09:52:00AM -0600, Eric Sandeen wrote:
> Just minor housekeeping, a lot more functions can be trivially
> made static; others could if we reordered things a bit...
Only one minor comment:
> -void
> +STATIC_INLINE void
> xlog_put_bp(
> xfs_buf_t *bp)
> {
I'd change that as STATIC as Christoph's recent patch removed
STATIC_INLINE. gcc will inline it for us if it's a win....
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Improving XFS desktop performance?, Eric Sandeen |
|---|---|
| Next by Date: | Re: Improving XFS desktop performance?, Dave Chinner |
| Previous by Thread: | [PATCH] xfs: make several more functions static, Eric Sandeen |
| Next by Thread: | Re: [PATCH] xfs: make several more functions static, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |