| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/7] xfs: kill the STATIC_INLINE macro |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 16 Nov 2009 14:20:57 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20091114161801.978180093@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20091114161717.233372584@xxxxxxxxxxxxxxxxxxxxxx> <20091114161801.978180093@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Sat, Nov 14, 2009 at 11:17:22AM -0500, Christoph Hellwig wrote: > Remove our own STATIC_INLINE macro. For small function inside implementation > files just use STATIC and let gcc inline it, and for those in headers do the > normal static inline - they are all small enough to be inlined for debug > builds, too. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good. Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 4/7] xfs: uninline xfs_get_extsz_hint, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 6/7] xfs: remove incorrect sparse annotation for xfs_iget_cache_miss, Dave Chinner |
| Previous by Thread: | [PATCH 5/7] xfs: kill the STATIC_INLINE macro, Christoph Hellwig |
| Next by Thread: | [PATCH 6/7] xfs: remove incorrect sparse annotation for xfs_iget_cache_miss, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |