| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/7] xfs: rename xfs_attr_fetch to xfs_attr_get_int |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 16 Nov 2009 14:17:02 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20091114161801.612419979@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20091114161717.233372584@xxxxxxxxxxxxxxxxxxxxxx> <20091114161801.612419979@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Sat, Nov 14, 2009 at 11:17:20AM -0500, Christoph Hellwig wrote: > Using a totally different name for the lowlevel get operation does not > fit the _int convention used in the rest of the attr code, so rename it. > > While we're at it also fix the prototype to use the normal convention > and mark it static as it's never used outside of xfs_attr.c. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks OK. Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 2/7] xfs: remove xfs_buf_get / xfs_buf_read, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 4/7] xfs: uninline xfs_get_extsz_hint, Dave Chinner |
| Previous by Thread: | [PATCH 3/7] xfs: rename xfs_attr_fetch to xfs_attr_get_int, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 3/7] xfs: rename xfs_attr_fetch to xfs_attr_get_int, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |