| To: | Alex Elder <aelder@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: fix mmap_sem vs iolock lock order inversion inxfs_free_eofblocks |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 3 Nov 2009 09:51:52 -0500 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <1AB9A794DBDDF54A8A81BE2296F7BDFE83AE5C@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20091019040346.GB21115@xxxxxxxxxxxxx> <1AB9A794DBDDF54A8A81BE2296F7BDFE83AE5C@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Mon, Nov 02, 2009 at 03:10:33PM -0600, Alex Elder wrote: > I have a minor suggestion below, but it looks correct to me. > I tried to get a better idea of what the conditions were > where mmap_sem would be held by VM when ->release gets > called, but didn't get to the bottom of that. If it is > easily characterized you could mention it in comments. It's the VMA merging code. But IMHO that's too much of an implementation detail to put into the comment here. Commit message might be fine. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.6.31 xfs_fs_destroy_inode: cannot reclaim, Patrick Schreurs |
|---|---|
| Next by Date: | Re: [PATCH] xfs: reset the i_iolock lock class in the reclaim path, Christoph Hellwig |
| Previous by Thread: | RE: [PATCH] xfs: fix mmap_sem vs iolock lock order inversion inxfs_free_eofblocks, Alex Elder |
| Next by Thread: | Re: 2.6.31+2.6.31.4: XFS - All I/O locks up to D-state after 24-48 hours (sysrq-t+w available), Justin Piszcz |
| Indexes: | [Date] [Thread] [Top] [All Lists] |