| To: | Theodore Tso <tytso@xxxxxxx> |
|---|---|
| Subject: | Re: ext4 writepages is making tiny bios? |
| From: | Jens Axboe <jens.axboe@xxxxxxxxxx> |
| Date: | Fri, 4 Sep 2009 09:20:13 +0200 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <20090904001545.GA30759@xxxxxxx> |
| References: | <20090901184450.GB7885@think> <20090901205744.GE6996@xxxxxxx> <20090901212740.GA9930@xxxxxxxxxxxxx> <20090903055201.GA7146@xxxxxxxxxxxxxxxx> <20090903164209.GA28384@xxxxxxxxxxxxx> <20090904001545.GA30759@xxxxxxx> |
On Thu, Sep 03 2009, Theodore Tso wrote: > On Thu, Sep 03, 2009 at 12:42:09PM -0400, Christoph Hellwig wrote: > > > Careful: > > > > > > - tloff = min(tlast, startpage->index + 64); > > > + tloff = min(tlast, startpage->index + 8192); > > > > > > That will cause 64k page machines to try to write back 512MB at a > > > time. This will re-introduce similar to the behaviour in sles9 where > > > writeback would only terminate at the end of an extent (because the > > > mapping end wasn't capped like above). > > > > Pretty good point, any applies to all the different things we discussed > > recently. Ted, should be maybe introduce a max_writeback_mb instead of > > the max_writeback_pages in the VM, too? > > Good point. > > Jens, maybe we should replace my patch with this one, which makes the > tunable in terms of megabytes instead of pages? That is probably a better metric than 'pages', lets update it. -- Jens Axboe |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 00/14] repair memory usage reductions, Dave Chinner |
|---|---|
| Next by Date: | Re: xfs data loss, Andi Kleen |
| Previous by Thread: | Re: ext4 writepages is making tiny bios?, Theodore Tso |
| Next by Thread: | Re: [stable] [PATCH 0/4] 2.6.30-stable backport of the XFS+NFSD inode cache race fix, Greg KH |
| Indexes: | [Date] [Thread] [Top] [All Lists] |