| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 07/17] vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode |
| From: | Jan Kara <jack@xxxxxxx> |
| Date: | Thu, 20 Aug 2009 14:15:31 +0200 |
| Cc: | Jan Kara <jack@xxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Evgeniy Polyakov <zbr@xxxxxxxxxxx>, ocfs2-devel@xxxxxxxxxxxxxx, Joel Becker <joel.becker@xxxxxxxxxx>, Felix Blyakher <felixb@xxxxxxx>, xfs@xxxxxxxxxxx, Anton Altaparmakov <aia21@xxxxxxxxxx>, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, tytso@xxxxxxx |
| In-reply-to: | <20090819162638.GE6150@xxxxxxxxxxxxx> |
| References: | <1250697884-22288-1-git-send-email-jack@xxxxxxx> <1250697884-22288-8-git-send-email-jack@xxxxxxx> <20090819162638.GE6150@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Wed 19-08-09 12:26:38, Christoph Hellwig wrote:
> Looks good to me. Eventually we should use those SYNC_ flags also all
> through the fsync codepath, but I'll see if I can incorporate that in my
> planned fsync rewrite.
Yes, I thought I'll leave that for later. BTW it should be fairly easy to
teach generic_sync_file() to do fdatawait() before calling ->fsync() if the
filesystem sets some flag in inode->i_mapping (or somewhere else) as is
needed for XFS, btrfs, etc.
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
|
| Previous by Date: | View Mechanica Simulation & Analysis Demo â Increase Innovation, PTC Info |
|---|---|
| Next by Date: | Re: [PATCH 14/17] xfs: Use new syncing helper, Jan Kara |
| Previous by Thread: | Re: [PATCH 07/17] vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 07/17] vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |