Re: [PATCH] Add ext2/3/4-specific _check_extN_filesystem function

[Theodore Tso <tytso@xxxxxxx>]

On Tue, Aug 18, 2009 at 12:11:16PM -0400, Christoph Hellwig wrote:
> On Tue, Aug 18, 2009 at 10:57:47AM -0400, Theodore Ts'o wrote:
> > The _check_generic_filesystem function doesn't force a full filesystem
> > check, so filesystem inconsistencies after a test wouldn't be noticed.
> > To fix this, I added an extN specific check filesystem function.
> 
> Looks like the only difference between the generic and the extN
> check routine is the addition of -f to the fsck command line.  What
> about just introducing a _fsck_args similar to _mount_opts where
> filesystems can set their additional required mount options?

That would work, yeah, and would be result in far less code
duplication in common.rc.  I'll take a whack at it and resubmit.

Thanks,

                                                - Ted