| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 7/9] xfs: switch to NOFS allocation under i_lock in xfs_attr_rmtval_set |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sat, 18 Jul 2009 18:14:59 -0400 |
| Cc: | sage@xxxxxxxxxxxx |
| References: | <20090718221452.594956000@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | quilt/0.47-1 |
xfs_attr_rmtval_set is always called with i_lock held, and i_lock is taken
in reclaim context so all allocations under it must avoid recursions into
the filesystem.
Reported by the new reclaim context tracing in lockdep.
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Index: linux-2.6/fs/xfs/xfs_attr.c
===================================================================
--- linux-2.6.orig/fs/xfs/xfs_attr.c 2009-07-18 18:49:20.129533080 +0200
+++ linux-2.6/fs/xfs/xfs_attr.c 2009-07-18 18:50:01.713535041 +0200
@@ -2141,8 +2141,8 @@ xfs_attr_rmtval_set(xfs_da_args_t *args)
dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock),
blkcnt = XFS_FSB_TO_BB(mp, map.br_blockcount);
- bp = xfs_buf_get_flags(mp->m_ddev_targp, dblkno,
- blkcnt, XFS_BUF_LOCK);
+ bp = xfs_buf_get_flags(mp->m_ddev_targp, dblkno, blkcnt,
+ XFS_BUF_LOCK | XBF_DONT_BLOCK);
ASSERT(bp);
ASSERT(!XFS_BUF_GETERROR(bp));
|
| Previous by Date: | [PATCH 5/9] xfs: switch to NOFS allocation under i_lock in xfs_dir_cilookup_result, Christoph Hellwig |
|---|---|
| Next by Date: | [PATCH 0/9] fixes for memory allocator recursions into the filesystem, Christoph Hellwig |
| Previous by Thread: | [PATCH 5/9] xfs: switch to NOFS allocation under i_lock in xfs_dir_cilookup_result, Christoph Hellwig |
| Next by Thread: | [PATCH 8/9] xfs: switch to NOFS allocation under i_lock in xfs_readlink_bmap, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |