| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 2/9] xfs: switch to NOFS allocation under i_lock in xfs_getbmap |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sat, 18 Jul 2009 18:14:54 -0400 |
| Cc: | sage@xxxxxxxxxxxx |
| References: | <20090718221452.594956000@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | quilt/0.47-1 |
xfs_getbmap allocates memory with i_lock held, but i_lock is taken in
reclaim context so all allocations under it must avoid recursions into
the filesystem.
Reported by the new reclaim context tracing in lockdep.
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Index: linux-2.6/fs/xfs/xfs_bmap.c
===================================================================
--- linux-2.6.orig/fs/xfs/xfs_bmap.c 2009-07-10 13:05:24.808364312 +0200
+++ linux-2.6/fs/xfs/xfs_bmap.c 2009-07-10 13:16:00.830363579 +0200
@@ -6009,7 +6009,7 @@ xfs_getbmap(
*/
error = ENOMEM;
subnex = 16;
- map = kmem_alloc(subnex * sizeof(*map), KM_MAYFAIL);
+ map = kmem_alloc(subnex * sizeof(*map), KM_MAYFAIL | KM_NOFS);
if (!map)
goto out_unlock_ilock;
|
| Previous by Date: | [PATCH 9/9] xfs: switch to NOFS allocation under i_lock in xfs_attr_rmtval_get, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] xfstests 219: test fiemap, Christoph Hellwig |
| Previous by Thread: | [PATCH 9/9] xfs: switch to NOFS allocation under i_lock in xfs_attr_rmtval_get, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 0/9] fixes for memory allocator recursions into the filesystem, Sage Weil |
| Indexes: | [Date] [Thread] [Top] [All Lists] |