| To: | "Theodore Ts'o" <tytso@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Fix _require_scratch test for extN, resierfs, gfs2, and btrfs |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sat, 20 Jun 2009 13:07:03 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1245443301-27495-1-git-send-email-tytso@xxxxxxx> |
| References: | <7D909252-70A0-44C2-A5D7-D56A4B6CD244@xxxxxxx> <1245443301-27495-1-git-send-email-tytso@xxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Fri, Jun 19, 2009 at 04:28:21PM -0400, Theodore Ts'o wrote: > The extN, reiserfs, gfs2, and btrfs filesysytem types should use the > same check for a block device as XFS and UDF, and not the test for > NFS, which was checking for host:/foo/bar/baz when checking for a > scratch device. > > Also, the NFS logic was also incorrect, in that it would allow a > zero-length SCRATCH_DEV to continue. Thanks, I've applied this with a small modification to make the local disk case the default in the case statement so that we don't have to touch this function when adding support for additional local filesystems. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/3] Skip _check_test_fs unless a test is actually run, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/3] Fix common.config to allow SCRATCH_DEV and SCRATCH_MNT to be optional, Christoph Hellwig |
| Previous by Thread: | [PATCH] Fix _require_scratch test for extN, resierfs, gfs2, and btrfs, Theodore Ts'o |
| Next by Thread: | [PATCH 2/3] Fix common.config to allow SCRATCH_DEV and SCRATCH_MNT to be optional, Theodore Ts'o |
| Indexes: | [Date] [Thread] [Top] [All Lists] |