xfs
[Top] [All Lists]

Re: [PATCH 2/9] Make libxfs.h optional

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 2/9] Make libxfs.h optional
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 28 May 2009 11:35:17 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4A1EA6E5.50805@xxxxxxxxxxx>
References: <1243450413-12681-1-git-send-email-sandeen@xxxxxxxxxxx> <1243450413-12681-3-git-send-email-sandeen@xxxxxxxxxxx> <20090528095749.GB651@xxxxxxxxxxxxx> <4A1EA6E5.50805@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, May 28, 2009 at 09:59:49AM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > On Wed, May 27, 2009 at 01:53:26PM -0500, Eric Sandeen wrote:
> >> libxfs.h is really only needed for the loggen test;
> >> make it config-time optional.
> > 
> > Maybe we should just move loggen into xfsprogs?
> 
> Perhaps, though it has no use outside of qa ... even if we do that it'll
> take a while to trickle into people's xfsprogs, so any problem with
> putting this patch in for now, even if we move loggen?

I will send a patch to add loggen to xfsprogs ASAP.  After that we can
remove loggen and thus the requirement for libxfs.h from xfstests
completely.  The tests that use loggen would ismply check for a
xfs_loggen binary  in their PATH and not run, so far less drama then
the current situation.

> 
> Thanks,
> -Eric
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---

<Prev in Thread] Current Thread [Next in Thread>