Re: [PATCH] drop xfs_version.h

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Tue, May 26, 2009 at 02:35:58PM -0500, Eric Sandeen wrote:
> xfs_version.h is about 30 lines for the benefit of 
> one single define, which seems a bit silly.
> 
> Just drop the file and hardcode "SGI XFS" the 2 
> places it's used.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

> -     printk(KERN_INFO XFS_VERSION_STRING " with "
> +     printk(KERN_INFO "SGI XFS with "
>                        XFS_BUILD_OPTIONS " enabled\n");

To prove that I can nitpick about even the most trivial patch:
shouldn't this be merged into a single line now? :)

Otherwise looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>