| To: | Felix Blyakher <felixb@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: fix async io error handling in fsx |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 6 Apr 2009 12:33:31 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1239031576-26279-1-git-send-email-felixb@xxxxxxx> |
| References: | <1239031576-26279-1-git-send-email-felixb@xxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Mon, Apr 06, 2009 at 10:26:16AM -0500, Felix Blyakher wrote: > The result of async io returned in the event.res in addition > to the number of bytes read/written provides negated error > number. The broken libaio defines event.res as unsigned > while the same structure in the kernel defines it as signed. > The kernel indeed treats it as signed, and returns the > negated error number. Till libaio is fixed we provide > the signed long temp var. > Also set errno for each error condition in aio_rw, as the > caller is not aio aware and expects ret(-1)+errno by the > traditional libc convention. Looks good. Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfstests: fix async io error handling in fsx, Felix Blyakher |
|---|---|
| Next by Date: | Re: why xfs_write() race with O_DIRECT only?, Christoph Hellwig |
| Previous by Thread: | [PATCH] xfstests: fix async io error handling in fsx, Felix Blyakher |
| Next by Thread: | Re: [PATCH] xfstests: fix async io error handling in fsx, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |