Re: [PATCH 5/5] xfs: remove m_attroffset

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Mar 26, 2009 at 03:42:06PM -0400, Josef 'Jeff' Sipek wrote:
> On Wed, Mar 18, 2009 at 05:41:24AM -0400, Christoph Hellwig wrote:
> > With the upcoming v3 inodes the default attroffset needs to be calculated
> > for each specific inode, so we can't cache it in the superblock anymore.
> > 
> > Also replace the assert for wrong inode sizes with a proper error check
> > also included in non-debug builds.  Note that the ENOSYS retourn for
>                                                            ^^^^^^^
> 
> Typo.
> 
> Otherwise it makes sense.
> 
> Josef 'Jeff' Sipek.
> 
> P.S. feel free to consider this an acked-by

Acked or reviewed?  This matters as I still need a formal review for
this one..