| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] XFS: Inform the xfsaild of the push target before sleeping |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 16 Mar 2009 06:38:36 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1237117243-25940-3-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1237117243-25940-1-git-send-email-david@xxxxxxxxxxxxx> <1237117243-25940-3-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
This looks good to me. Reviewed-by: Christoph Hellwig <hch@xxxxxx> But looking at that area I must say I'm not happy with it in general. There are tons of useless roundtrips l_grant_lock because we drop it just before calling xlog_grant_push_ail which needs it for most of it's operation, and because we acquire it just before sv_wait just to drop it. And the duplication between xlog_grant_log_space xlog_regrant_write_log_space is quite ugly, too. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/2] XFS: Prevent unwritten extent conversion from blocking I/O completion, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 2/5] [XFS] Make inode flush at ENOSPC synchronous, Dave Chinner |
| Previous by Thread: | [PATCH 2/2] XFS: Inform the xfsaild of the push target before sleeping, Dave Chinner |
| Next by Thread: | Re: [PATCH 2/2] XFS: Inform the xfsaild of the push target before sleeping, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |