Re: [PATCH 1/2] [XFS] Validate log feature fields correctly

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Sun, Mar 15, 2009 at 10:25:41PM +1100, Dave Chinner wrote:
> If the large log sector size feature bit is set in the
> superblock by accident (say disk corruption), the then
> fields that are now considered valid are not checked on
> production kernels. The checks are present as ASSERT
> statements so cause a panic on a debug kernel.
> 
> Change this so that the fields are validity checked if
> the feature bit is set and abort the log mount if the
> fields do not contain valid values.
> 
> Reported-by: Eric Sesterhenn <snakebyte@xxxxxx>
> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

Looks good to me, but wouldn't be easier to rad if the various sizes
in the error messages were reported decimal instead of in hex?


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

>  }    /* xlog_alloc_log */

any maybe remove this comment while you're at it?