xfs
[Top] [All Lists]

Re: next-20090220: XFS, IMA: BUG: sleeping function called from invalid

To: Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx>
Subject: Re: next-20090220: XFS, IMA: BUG: sleeping function called from invalid context at mm/slub.c:1613
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 20 Feb 2009 14:28:07 -0800
Cc: a.beregalov@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, jmorris@xxxxxxxxx
In-reply-to: <1235168219.3019.4.camel@xxxxxxxxxxxxxxxxxxxxx>
References: <a4423d670902200300n1d1bfdeeg6daca4b32989c9d3@xxxxxxxxxxxxxx> <20090220122242.b36a778f.akpm@xxxxxxxxxxxxxxxxxxxx> <1235168219.3019.4.camel@xxxxxxxxxxxxxxxxxxxxx>
On Fri, 20 Feb 2009 17:16:59 -0500
Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:

> integrity: ima iint radix_tree_lookup locking fix
> 
> Based on Andrew Morton's comments:
> - add missing locks around radix_tree_lookup in ima_iint_insert()
> 
> Signed-off-by: Mimi Zohar <zohar@xxxxxxxxxx>
> 
> Index: security-testing-2.6/security/integrity/ima/ima_iint.c
> ===================================================================
> --- security-testing-2.6.orig/security/integrity/ima/ima_iint.c
> +++ security-testing-2.6/security/integrity/ima/ima_iint.c
> @@ -73,8 +73,10 @@ out:
>       if (rc < 0) {
>               kmem_cache_free(iint_cache, iint);
>               if (rc == -EEXIST) {
> +                     spin_lock(&ima_iint_lock);
>                       iint = radix_tree_lookup(&ima_iint_store,
>                                                (unsigned long)inode);
> +                     spin_unlock(&ima_iint_lock);
>               } else
>                       iint = NULL;
>       }

Can the -EEXIST ever actually happen?

On the inode_init_always() path (at least), I don't think that any
other thread of control can have access to this inode*, so there is no
way in which a race can result in someone else adding this inode
first?


Also, idle question: why does the radix tree exist at all?  Would it
have been possible to just add a `struct ima_iint_cache *' field to the
inode instead?

<Prev in Thread] Current Thread [Next in Thread>