Re: [PATCH] Re: Corrupted XFS log replay oops.

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Thu, Jan 22, 2009 at 01:11:58AM -0500, Christoph Hellwig wrote:
> On Thu, Jan 22, 2009 at 03:37:47PM +1100, Dave Chinner wrote:
> >  xfs_buf_t *
> >  xlog_get_bp(
> >     xlog_t          *log,
> > -   int             num_bblks)
> > +   int             nbblks)
> 
> Any reason for reanming this variable?  That causes quite a bit of
> churn.

Just so it was the same variable name as the other I/O functions
around it. It's kind of strange to have one function use num_bblks
and another 4 or so related functions use nbblks....

> >  {
> > -   ASSERT(num_bblks > 0);
> > +   if (nbblks <= 0 || nbblks > log->l_logBBsize) {
> > +           xlog_warn("XFS: Invalid block length (0x%x) given for buffer", 
> > nbblks);
> 
> And doesn't prevent this line from needing a linebreak to stay under 80
> characters :)

I'll respin it to fix this.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx