| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 6/7] xfs: fix bad_features2 fixups for the root filesystem |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 12 Jan 2009 10:03:10 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20090109221301.289471000@bombadil.infradead.org> |
| Mail-followup-to: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| References: | <20090109221104.237540000@bombadil.infradead.org> <20090109221301.289471000@bombadil.infradead.org> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Fri, Jan 09, 2009 at 05:11:10PM -0500, Christoph Hellwig wrote: > Currently the bad_features2 fixup and the alignment updates in the superblock > are skipped if we mount a filesystem read-only. But for the root filesystem > the typical case is to mount read-only first and only later remount writeable > so we'll never perform this update at all. It's not a big problem but means > the logs of people needing the fixup get spammed at every boot because they > never happen on disk. > > Reported-by: Arkadiusz Miskiewicz <arekm@xxxxxxxx> > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks sane. Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 1/7] xfs: fix dentry aliasing issues in open_by_handle, Dave Chinner |
|---|---|
| Next by Date: | Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108, Alexander Beregalov |
| Previous by Thread: | [PATCH 6/7] xfs: fix bad_features2 fixups for the root filesystem, Christoph Hellwig |
| Next by Thread: | [PATCH 7/7] xfs: sanity check attr fork size, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |