Re: [PATCH] remove always-true #ifndef HAVE

xfs

Re: [PATCH] remove always-true #ifndef HAVE_FORMAT32 tests

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH] remove always-true #ifndef HAVE_FORMAT32 tests
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 2 Jan 2009 12:59:58 -0500
Cc:	xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<495D48B3.2080708@sandeen.net>
References:	<495D48B3.2080708@sandeen.net>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Thu, Jan 01, 2009 at 04:50:27PM -0600, Eric Sandeen wrote:
> There are several tests for #ifndef HAVE_FORMAT32, but
> this is never defined anywhere so it is always the default
> behavior; just remove the ifndef goop.

Looks good to me.  I can't see any reason why you'd want to
defined these in a different place.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] remove always-true #ifndef HAVE_FORMAT32 tests, Eric Sandeen Re: [PATCH] remove always-true #ifndef HAVE_FORMAT32 tests, Christoph Hellwig <=

Previous by Date:	*Re: oopses in xfs_attr_shortform_ on kerneloops.org*, Christoph Hellwig*
Next by Date:	Re: [PATCH] create xfstests install target, Christoph Hellwig
Previous by Thread:	[PATCH] remove always-true #ifndef HAVE_FORMAT32 tests, Eric Sandeen
Next by Thread:	Re: xfsaild wakeups, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]