Re: [patch 08/22] reduce l_icloglock roundtrips

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [patch 08/22] reduce l_icloglock roundtrips
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 3 Dec 2008 13:56:14 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20081202160650.663976000@bombadil.infradead.org>
Mail-followup-to:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References:	<20081202160430.775774000@bombadil.infradead.org> <20081202160650.663976000@bombadil.infradead.org>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Tue, Dec 02, 2008 at 11:04:38AM -0500, Christoph Hellwig wrote:
> All but one caller of xlog_state_want_sync drop and re-acquire
> l_icloglock around the call to it, just so that xlog_state_want_sync can
> acquire and drop it.

Not really a performance problem, though, because the one caller
that doesn't already hold the lock is the common path (i.e.
xlog_write()); the others are in the  unmount path, so lock traffic
is not there is not performance critical....

Hence I'm not sure this is really necessary.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [patch 16/22] use xfs_trans_ijoin in xfs_trans_iget, (continued) Re: [patch 16/22] use xfs_trans_ijoin in xfs_trans_iget, Dave Chinner [patch 01/22] fix compile on 32 bit systems, Christoph Hellwig Re: [patch 01/22] fix compile on 32 bit systems, Eric Sandeen Re: [patch 01/22] fix compile on 32 bit systems, Eric Sandeen Re: [patch 01/22] fix compile on 32 bit systems, Niv Sardi Re: [patch 01/22] fix compile on 32 bit systems, Christoph Hellwig Re: [patch 01/22] fix compile on 32 bit systems, Niv Sardi Re: [patch 01/22] fix compile on 32 bit systems, Christoph Hellwig Re: [patch 01/22] fix compile on 32 bit systems, Niv Sardi [patch 08/22] reduce l_icloglock roundtrips, Christoph Hellwig Re: [patch 08/22] reduce l_icloglock roundtrips, Dave Chinner <= Re: [patch 08/22] reduce l_icloglock roundtrips, Christoph Hellwig [patch 12/22] kill dead inode flags, Christoph Hellwig Re: [patch 12/22] kill dead inode flags, Dave Chinner Re: [patch 12/22] kill dead inode flags, Niv Sardi Re: [patch 12/22] kill dead inode flags, Christoph Hellwig [patch 03/22] remove unused behvavior cruft in xfs_super.h, Christoph Hellwig Re: [patch 03/22] remove unused behvavior cruft in xfs_super.h, Dave Chinner [patch 06/22] kill xfs_buf_iostart, Christoph Hellwig Re: [patch 06/22] kill xfs_buf_iostart, Dave Chinner [patch 07/22] stop using igrab in xfs_vn_link, Christoph Hellwig

Previous by Date:	Re: [patch 07/22] stop using igrab in xfs_vn_link, Dave Chinner
Next by Date:	Re: [patch 10/22] kill dead quota flags, Dave Chinner
Previous by Thread:	[patch 08/22] reduce l_icloglock roundtrips, Christoph Hellwig
Next by Thread:	Re: [patch 08/22] reduce l_icloglock roundtrips, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]