Re: [patch 08/12] Fix compat XFS_IOC_FSBULKSTAT

Re: [patch 08/12] Fix compat XFS_IOC_FSBULKSTAT_SINGLE ioctl

To:	sandeen@xxxxxxxxxxx
Subject:	Re: [patch 08/12] Fix compat XFS_IOC_FSBULKSTAT_SINGLE ioctl
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 26 Nov 2008 05:35:11 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20081126032028.730961152@sandeen.net>
References:	<20081126032005.639750968@sandeen.net> <20081126032028.730961152@sandeen.net>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Tue, Nov 25, 2008 at 09:20:13PM -0600, sandeen@xxxxxxxxxxx wrote:
> The XFS_IOC_FSBULKSTAT_SINGLE ioctl passes in the
> desired inode number, while XFS_IOC_FSBULKSTAT passes
> in the previous/last-stat'd inode number.  The
> compat handler wasn't differentiating these, so
> when a XFS_IOC_FSBULKSTAT_SINGLE request for inode
> 128 was sent in, stat information for 131 was sent out.

Looks good.

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 00/12] [PATCH V2]: compat ioctl fixes/cleanups/additions, sandeen [patch 08/12] Fix compat XFS_IOC_FSBULKSTAT_SINGLE ioctl, sandeen Re: [patch 08/12] Fix compat XFS_IOC_FSBULKSTAT_SINGLE ioctl, Christoph Hellwig <= [patch 06/12] Make the bulkstat_one compat ioctl handling more sane, sandeen Re: [patch 06/12] Make the bulkstat_one compat ioctl handling more sane, Christoph Hellwig [patch 04/12] Add compat handlers for swapext ioctl, sandeen Re: [patch 04/12] Add compat handlers for swapext ioctl, Christoph Hellwig [patch 11/12] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler, sandeen Re: [patch 11/12] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler, Christoph Hellwig [patch 12/12] Reorder xfs_ioctl32.c for some tidiness, sandeen Re: [patch 12/12] Reorder xfs_ioctl32.c for some tidiness, Christoph Hellwig [patch 09/12] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, sandeen Re: [patch 09/12] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, Christoph Hellwig

Previous by Date:	Re: [patch 07/12] Fix xfs_bulkstat_one size checks & error handling, Christoph Hellwig
Next by Date:	Re: [patch 09/12] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, Christoph Hellwig
Previous by Thread:	[patch 08/12] Fix compat XFS_IOC_FSBULKSTAT_SINGLE ioctl, sandeen
Next by Thread:	[patch 06/12] Make the bulkstat_one compat ioctl handling more sane, sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]