Re: [patch 07/12] Fix xfs_bulkstat_one size checks & error handling

To:	sandeen@xxxxxxxxxxx
Subject:	Re: [patch 07/12] Fix xfs_bulkstat_one size checks & error handling
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 26 Nov 2008 05:34:47 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20081126032028.571084174@sandeen.net>
References:	<20081126032005.639750968@sandeen.net> <20081126032028.571084174@sandeen.net>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Tue, Nov 25, 2008 at 09:20:12PM -0600, sandeen@xxxxxxxxxxx wrote:
> The 32-bit xfs_blkstat_one handler was failing because
> a size check checked whether the remaining (32-bit)
> user buffer was less than the (64-bit) bulkstat buffer,
> and failed with ENOMEM if so.  Move this check
> into the respective handlers so that they check the
> correct sizes.
> 
> Also, the formatters were returning negative errors
> or positive bytes copied; this was odd in the positive
> error value world of xfs, and handled wrong by at least
> some of the callers, which treated the bytes returned
> as an error value.  Move the bytes-used assignment
> into the formatters

Looks good.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [patch 11/12] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler, (continued) Re: [patch 11/12] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler, Christoph Hellwig [patch 12/12] Reorder xfs_ioctl32.c for some tidiness, sandeen Re: [patch 12/12] Reorder xfs_ioctl32.c for some tidiness, Christoph Hellwig [patch 09/12] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, sandeen Re: [patch 09/12] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, Christoph Hellwig [patch 10/12] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, sandeen Re: [patch 10/12] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, Christoph Hellwig [patch 05/12] Add compat handlers for data & rt growfs ioctls, sandeen Re: [patch 05/12] Add compat handlers for data & rt growfs ioctls, Christoph Hellwig [patch 07/12] Fix xfs_bulkstat_one size checks & error handling, sandeen Re: [patch 07/12] Fix xfs_bulkstat_one size checks & error handling, Christoph Hellwig <= [patch 01/12] Move copy_from_user calls out of ioctl helpers into ioctl switch., sandeen Re: [patch 01/12] Move copy_from_user calls out of ioctl helpers into ioctl switch., Christoph Hellwig [patch 02/12] Move compat ioctl structs & numbers into xfs_ioctl32.h, sandeen Re: [patch 02/12] Move compat ioctl structs & numbers into xfs_ioctl32.h, Christoph Hellwig [patch 03/12] Clean up some existing compat ioctl calls, sandeen Re: [patch 03/12] Clean up some existing compat ioctl calls, Christoph Hellwig Re: [patch 00/12] [PATCH V2]: compat ioctl fixes/cleanups/additions, Eric Sandeen Re: [patch 00/12] [PATCH V2]: compat ioctl fixes/cleanups/additions, Eric Sandeen Re: [patch 00/12] [PATCH V2]: compat ioctl fixes/cleanups/additions, Russell Cattelan

Previous by Date:	Re: [patch 05/12] Add compat handlers for data & rt growfs ioctls, Christoph Hellwig
Next by Date:	Re: [patch 08/12] Fix compat XFS_IOC_FSBULKSTAT_SINGLE ioctl, Christoph Hellwig
Previous by Thread:	[patch 07/12] Fix xfs_bulkstat_one size checks & error handling, sandeen
Next by Thread:	[patch 01/12] Move copy_from_user calls out of ioctl helpers into ioctl switch., sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]