Re: [patch 06/12] Make the bulkstat_one compat ioctl handling more sane

To:	sandeen@xxxxxxxxxxx
Subject:	Re: [patch 06/12] Make the bulkstat_one compat ioctl handling more sane
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 26 Nov 2008 05:33:33 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20081126032028.382309095@sandeen.net>
References:	<20081126032005.639750968@sandeen.net> <20081126032028.382309095@sandeen.net>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Tue, Nov 25, 2008 at 09:20:11PM -0600, sandeen@xxxxxxxxxxx wrote:
> Currently the compat formatter was handled by passing
> in "private_data" for the xfs_bulkstat_one formatter,
> which was really just another formatter... IMHO this
> got confusing.
> 
> Instead, just make a new xfs_bulkstat_one_compat
> formatter for xfs_bulkstat, and call it via a wrapper.
> 
> Also, don't translate the ioctl nrs into their native
> counterparts, that just clouds the issue; we're in a
> compat handler anyway, just switch on the 32-bit cmds.

Looks good.

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 00/12] [PATCH V2]: compat ioctl fixes/cleanups/additions, sandeen [patch 08/12] Fix compat XFS_IOC_FSBULKSTAT_SINGLE ioctl, sandeen Re: [patch 08/12] Fix compat XFS_IOC_FSBULKSTAT_SINGLE ioctl, Christoph Hellwig [patch 06/12] Make the bulkstat_one compat ioctl handling more sane, sandeen Re: [patch 06/12] Make the bulkstat_one compat ioctl handling more sane, Christoph Hellwig <= [patch 04/12] Add compat handlers for swapext ioctl, sandeen Re: [patch 04/12] Add compat handlers for swapext ioctl, Christoph Hellwig [patch 11/12] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler, sandeen Re: [patch 11/12] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler, Christoph Hellwig [patch 12/12] Reorder xfs_ioctl32.c for some tidiness, sandeen Re: [patch 12/12] Reorder xfs_ioctl32.c for some tidiness, Christoph Hellwig [patch 09/12] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, sandeen Re: [patch 09/12] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, Christoph Hellwig [patch 10/12] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, sandeen Re: [patch 10/12] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, Christoph Hellwig

Previous by Date:	Re: [patch 09/12] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, Christoph Hellwig
Next by Date:	Re: [patch 10/12] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, Christoph Hellwig
Previous by Thread:	[patch 06/12] Make the bulkstat_one compat ioctl handling more sane, sandeen
Next by Thread:	[patch 04/12] Add compat handlers for swapext ioctl, sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]