On Thu, Oct 23, 2008 at 11:01:11PM -0500, Eric Sandeen wrote:
> Ok, got the kinks worked out of the delalloc portion of the
> fiemap hookup I think.
>
> This introduces a new input flag (BMV_IF_DELALLOC) and output
> flag (BMV_OF_DELALLOC) to request & show the delayed allocation
> segments.
....
> @@ -5827,6 +5827,7 @@ xfs_getbmap(
> * preallocated data space */
> int sh_unwritten; /* true, if unwritten */
> /* extents listed separately */
> + int sh_delalloc; /* show delayed extents */
> int iflags; /* interface flags */
> int bmapi_flags; /* flags for xfs_bmapi */
Do we really need this "sh_delalloc" flag? Checking for
(iflags & BMV_IF_DELALLOC) is fine by me, same for replacing
sh_unwritten. I've never really liked the "sh" abbreviation for
"show"....
Otherwise it looks ok. Perhaps we should also add delalloc extent
display to xfs_bmap....
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|