| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/3] XFS: Make use of the init-once slab optimisation. |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 15 Sep 2008 17:11:17 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1221314627-29065-3-git-send-email-david@fromorbit.com> |
| References: | <1221314627-29065-1-git-send-email-david@fromorbit.com> <1221314627-29065-3-git-send-email-david@fromorbit.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Sun, Sep 14, 2008 at 12:03:46AM +1000, Dave Chinner wrote: > To avoid having to initialise some fields of the XFS inode > on every allocation, we can use the slab init-once feature > to initialise them. All we have to guarantee is that when > we free the inode, all it's entries are in the initial state. > Add asserts where possible to ensure debug kernels check this > initial state before freeing and after allocation. This looks like it's already in: http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xaiki/xfs-linux-2.6-xfs-cvs/.git;a=commitdiff;h=12efb888674600ce73a64f8c6f4a20ea5e1ce4f1 |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: XFS does not recognise mount options in 2.6.27-rc6, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 3/3] XFS: Never call mark_inode_dirty_sync() directly, Christoph Hellwig |
| Previous by Thread: | [PATCH 2/3] XFS: Make use of the init-once slab optimisation., Dave Chinner |
| Next by Thread: | Re: [PATCH 2/3] XFS: Make use of the init-once slab optimisation., Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |