| To: | Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [REVIEW] Prevent direct I/O from mapping extents beyond eof |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 15 Aug 2008 18:40:47 -0400 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, lachlan@xxxxxxx, xfs-dev@xxxxxxx, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20080815152756.61aab5a7.akpm@linux-foundation.org> |
| References: | <48A50152.8020104@sgi.com> <20080815220958.GB13770@infradead.org> <20080815152756.61aab5a7.akpm@linux-foundation.org> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Fri, Aug 15, 2008 at 03:27:56PM -0700, Andrew Morton wrote: > Oh gee, I forget, and so many people have done drivebys on that code... > > We _could_ add additional i_size checking into direct-io.c but bear in > mind that it would be best-effort unreliable stuff. The code will > still be tripped up by concurrent extends and concurrent truncates. > > So we'll still end up calling the fs for blocks outside i_size, only > less commonly. I think. Yeah, guess we should put in this patch then. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [REVIEW] Prevent direct I/O from mapping extents beyond eof, Andrew Morton |
|---|---|
| Next by Date: | Re: [PATCH 5/7] XFS: Make use of the init-once slab optimisation., Dave Chinner |
| Previous by Thread: | Re: [REVIEW] Prevent direct I/O from mapping extents beyond eof, Andrew Morton |
| Next by Thread: | TAKE 985710 - stop rejecting options in remount, Tim Shimmin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |