On Wed, Jul 30, 2008 at 11:39:20AM +1000, Dave Chinner wrote:
> > + void (*trace_enter)(struct xfs_btree_cur *, const char *,
> > + char *, int, int, __psunsigned_t,
> > + __psunsigned_t, __psunsigned_t,
> > + __psunsigned_t, __psunsigned_t,
> > + __psunsigned_t, __psunsigned_t,
> > + __psunsigned_t, __psunsigned_t,
> > + __psunsigned_t, __psunsigned_t);
>
> Would it be better to use a 'trace args' structure here rather
> than passing a heap of parameters? memset(args, 0,...) rather than
> passing a whole heap of zeros in most cases seems like a better
> approach to me, esp. as they all get cast to (void *) anyway....
Well, we need to case to void * somewhere, and going from struct
to arguments list isn't helpful either.
Changing the whole ktrace thing to an args strucutr and/or varags
would be nice, but is not in scope for this patchset..
> > +static void
> > +xfsidb_btree_trace_record(
>
> shouldn't these all use "xfsidbg" prefixes?
Probably.
|