| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: TAKE 981498 - remove mounpoint UUID code |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 25 Jul 2008 15:01:49 +1000 |
| Cc: | Niv Sardi-Altivanik <xaiki@xxxxxxx>, sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <48894C66.5060204@sandeen.net> |
| Mail-followup-to: | Eric Sandeen <sandeen@xxxxxxxxxxx>, Niv Sardi-Altivanik <xaiki@xxxxxxx>, sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| References: | <20080725033841.D689558C4C3F@chook.melbourne.sgi.com> <48894C66.5060204@sandeen.net> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Thu, Jul 24, 2008 at 10:45:42PM -0500, Eric Sandeen wrote: > Niv Sardi-Altivanik wrote: > > remove mounpoint UUID code > > Are you sure this didn't change any disk structures? The patch I sent > was RFC and completely untested... (and disclosed as such...) :) Looking at the original patch, it definitely does change the format of log structures on disk. it removes the union of the uuid and rdev in the xfs_inode_log_format[32|64] which takes that entry from 16 bytes down to 4 bytes. So I'd suggest that thisss should be removed immediately before it hits public and people start corrupting their filesystems.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] kill INDUCE_IO_ERROR, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] kill INDUCE_IO_ERROR, Donald Douwsma |
| Previous by Thread: | Re: TAKE 981498 - remove mounpoint UUID code, Eric Sandeen |
| Next by Thread: | Re: TAKE 981498 - remove mounpoint UUID code, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |