On Tue, Jul 15, 2008 at 04:36:29PM +1000, Timothy Shimmin wrote:
> * in xfs_setattr we now explicitly set for linux inode:
> i_mode, i_uid, i_gid, i_atime, i_mtime, i_ctime
> It looks like we didn't set i_atime in vn_revalidate previously.
That was intentional because the VFS updates this one directly and
we already must only update it from setattr.
> This change looks weird:
> > */
> > - iattr.ia_mask = XFS_AT_MODE;
> > + iattr.ia_valid = ATTR_MODE;
> > iattr.ia_mode = xfs_vtoi(vp)->i_d.di_mode;
>
> I didn't think there was an ia_mask field - was this really
> from another patch? Confused.
That's because the previous patch did a botched bhv_vattr to iattr
conversion and I only noticed this when compiling the second patch
and accidentally fixed it there.
I've updated both patches to correct this and attached them.
xfs-simplify-xfs_setattr
Description: Text document
xfs-kill-vn_revalidate
Description: Text document
|