xfs
[Top] [All Lists]

Re: [PATCH] Introduce xfs_trans_bmap_add_attrfork.

To: Niv Sardi <xaiki@xxxxxxx>
Subject: Re: [PATCH] Introduce xfs_trans_bmap_add_attrfork.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 30 Jun 2008 08:02:21 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1214196150-5427-4-git-send-email-xaiki@sgi.com>
Mail-followup-to: Niv Sardi <xaiki@xxxxxxx>, xfs@xxxxxxxxxxx
References: <1214196150-5427-1-git-send-email-xaiki@sgi.com> <1214196150-5427-2-git-send-email-xaiki@sgi.com> <1214196150-5427-3-git-send-email-xaiki@sgi.com> <1214196150-5427-4-git-send-email-xaiki@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
On Mon, Jun 23, 2008 at 02:42:29PM +1000, Niv Sardi wrote:
> That takes a transaction and doesn't require everything to be locked
> anymore.  this uses the roll trans call.
.....
>  error2:
> +     if (tpp)
> +             tpp = &tp;

That's clearly busted.

        if (tpp)
                *tpp = tp;

>       xfs_bmap_cancel(&flist);
>  error1:
>       ASSERT(ismrlocked(&ip->i_lock,MR_UPDATE));
> -     xfs_iunlock(ip, XFS_ILOCK_EXCL);
> +     if (tpp)
> +             tpp = &tp;

ditto.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>