Re: [PATCH 1/6] Extend completions to provide XFS object flush requireme

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Thu, 26 Jun 2008 23:18:29 +1000
Cc:	xfs@xxxxxxxxxxx, matthew@xxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to:	<20080626130700.GA24325@infradead.org>
Mail-followup-to:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, matthew@xxxxxx, linux-kernel@xxxxxxxxxxxxxxx
References:	<1214455277-6387-1-git-send-email-david@fromorbit.com> <1214455277-6387-2-git-send-email-david@fromorbit.com> <20080626074636.GB7064@infradead.org> <20080626112133.GJ11558@disturbed> <20080626130700.GA24325@infradead.org>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.17+20080114 (2008-01-14)

On Thu, Jun 26, 2008 at 09:07:00AM -0400, Christoph Hellwig wrote:
> On Thu, Jun 26, 2008 at 09:21:33PM +1000, Dave Chinner wrote:
> > Ok, so that involves exactly what? A new header file, a new API name
> > (ideas anyone?) and kerneldoc comments?
> 
> Yes, probably just a new header with properly documented functions.
> Thew two non-trivial ones you added should probably not be inlines,
> btw.

Yeah, they grew a little bigger than expected...

> flush_lock_init/flush_lock/flush_trylock/flush_done/flush_is_locked?

Ok, I was thinking along those lines. I'll redo the patch series
using that interface tomorrow.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 2/6] Replace inode flush semaphore with a completion, (continued) Re: [PATCH 2/6] Replace inode flush semaphore with a completion, Dave Chinner [PATCH 6/6] Clean up stale references to semaphores, Dave Chinner Re: [PATCH 6/6] Clean up stale references to semaphores, Christoph Hellwig [PATCH 4/6] Replace the XFS buf iodone semaphore with a completion, Dave Chinner Re: [PATCH 4/6] Replace the XFS buf iodone semaphore with a completion, Christoph Hellwig [PATCH 3/6] Replace dquot flush semaphore with a completion, Dave Chinner [PATCH 1/6] Extend completions to provide XFS object flush requirements, Dave Chinner Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Christoph Hellwig Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Dave Chinner Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Christoph Hellwig Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Dave Chinner <= Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Matthew Wilcox Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Dave Chinner Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Matthew Wilcox Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Dave Chinner Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Matthew Wilcox Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Christoph Hellwig Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Dave Chinner Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Daniel Walker Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Dave Chinner Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Matthew Wilcox

Previous by Date:	Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Christoph Hellwig
Next by Date:	Re: [PATCH] disable queue flag test in barrier check, Eric Sandeen
Previous by Thread:	Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Christoph Hellwig
Next by Thread:	Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements, Matthew Wilcox
Indexes:	[Date] [Thread] [Top] [All Lists]