On Wed, Jun 18, 2008 at 02:45:11PM +1000, Donald Douwsma wrote:
> Christoph Hellwig wrote:
> >On Fri, May 23, 2008 at 08:23:23AM +0200, Christoph Hellwig wrote:
> >>All the error injection is already enabled through ifdef DEBUG, so kill
> >>the never set second cpp symbol to activate it without the rest of the
> >>debugging infrastructure.
> >
> >Can I get a review on this absolutely trivial patch?
>
> I'd like to keep INDUCE_IO_ERROR around so we have a way to introduce
> ioerrors in release builds during testing.
>
> We could add it to xfs.h with the commented out QUOTADEBUG so people
> know we still want to use it.
cpp symbols not exposed by Kconfig will never get tested. If you thing
it's really useful for release builds (which don't quite agree with) we
should just enable it unconditionally. It's just in a few places, and
any branch predictor worth it's name should take care of the additional
branches without visible cost.
|