xfs
[Top] [All Lists]

[patch] xfsqa 078 - use rmdir to remove directories

To: xfs-dev <xfs-dev@xxxxxxx>
Subject: [patch] xfsqa 078 - use rmdir to remove directories
From: David Chinner <dgc@xxxxxxx>
Date: Thu, 22 May 2008 16:11:20 +1000
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
If test 078 fails and you try to run it again immediately, it
will execute a 'rm -f' on a directory which will fail. This should
be a rmdir....

Signed-off-by: Dave Chinner <dgc@xxxxxxx>
---
 xfstests/078 |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: xfs-cmds/xfstests/078
===================================================================
--- xfs-cmds.orig/xfstests/078  2008-03-20 09:10:02.000000000 +1100
+++ xfs-cmds/xfstests/078       2008-05-15 23:21:58.192413673 +1000
@@ -50,8 +50,8 @@ _filter_io()
 # real QA test starts here
 
 echo "*** create loop mount point"
-rm -f $LOOP_MNT 2>/dev/null
-mkdir $LOOP_MNT || _fail "cannot create loopback mount point"
+rmdir $LOOP_MNT 2>/dev/null
+mkdir -p $LOOP_MNT || _fail "cannot create loopback mount point"
 
 _grow_loop()
 {


<Prev in Thread] Current Thread [Next in Thread>