xfs
[Top] [All Lists]

PARTIAL TAKE 981498 - kill xfs_igrow_start and xfs_igrow_finish

To: sgi.bugs.xfs@xxxxxxxxxxxx
Subject: PARTIAL TAKE 981498 - kill xfs_igrow_start and xfs_igrow_finish
From: dgc@xxxxxxx (David Chinner)
Date: Mon, 19 May 2008 17:24:35 +1000 (EST)
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
kill xfs_igrow_start and xfs_igrow_finish

xfs_igrow_start just expands to xfs_zero_eof with two asserts that are
useless in the context of the only caller and some rather confusing
comments.

xfs_igrow_finish is just a few lines of code decorated again with
useless asserts and confusing comments.

Just kill those two and merge them into xfs_setattr.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Date:  Mon May 19 17:24:15 AEST 2008
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  hch@xxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:31186a
fs/xfs/xfs_vnodeops.c - 1.759 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vnodeops.c.diff?r1=text&tr1=1.759&r2=text&tr2=1.758&f=h
        - kill xfs_igrow_start and xfs_igrow_finish.

fs/xfs/xfs_inode.c - 1.504 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.c.diff?r1=text&tr1=1.504&r2=text&tr2=1.503&f=h
        - kill xfs_igrow_start and xfs_igrow_finish.

fs/xfs/xfs_inode.h - 1.246 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.h.diff?r1=text&tr1=1.246&r2=text&tr2=1.245&f=h
        - kill xfs_igrow_start and xfs_igrow_finish.

fs/xfs/linux-2.6/xfs_ksyms.c - 1.84 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_ksyms.c.diff?r1=text&tr1=1.84&r2=text&tr2=1.83&f=h
        - kill xfs_igrow_start and xfs_igrow_finish.



<Prev in Thread] Current Thread [Next in Thread>
  • PARTIAL TAKE 981498 - kill xfs_igrow_start and xfs_igrow_finish, David Chinner <=