Re: [PATCH] Don't allow memory reclaim to wait on the filesystem in inode writeback

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, May 01, 2008 at 10:26:11PM +1000, David Chinner wrote:
> Index: 2.6.x-xfs-new/fs/xfs/xfs_inode.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/xfs_inode.c     2008-04-28 16:35:23.000000000 
> +1000
> +++ 2.6.x-xfs-new/fs/xfs/xfs_inode.c  2008-05-01 20:04:55.151880341 +1000
> @@ -2986,7 +2986,7 @@ xfs_iflush_cluster(
>       ASSERT(pag->pag_ici_init);
>  
>       ilist_size = XFS_INODE_CLUSTER_SIZE(mp) * sizeof(xfs_inode_t *);
> -     ilist = kmem_alloc(ilist_size, KM_MAYFAIL);
> +     ilist = kmem_alloc(ilist_size, KM_NOFS);
>       if (!ilist)
>               return 0;

This should be KM_MAYFAIL | KM_NOFS, because KM_NOFS doesn't imply that
the allocation may fail.