xfs
[Top] [All Lists]

Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
From: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>
Date: Mon, 28 Apr 2008 01:57:12 +0200
Cc: xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; bh=3zG05DkgIWiT8Ggo7/E5FJZh4SDd4fTlTWu4bmBWyDE=; b=MALz7Yf5K1fJf2nezIKdHN6L3AIX4u1HZI/6VnOHwrpI/lsPdNtlBn9Bih2EfNjpRb+JMTf7QrRF5BE+29YKhgImKSiteXqDSjWISgqGu9kbrGUMfo+jHitl56BCLo6wl7cbB4mtjDGc1QW0nGLpAWlFyxEE55LLwpG8cq7/bw0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=C+7Xz7vBKxyPuU7WEMe9vHbr9lwp1/At0RE4Ysl0pU0vLEIUbPW2h9+vZTj34quhZ536hUl6g1+H/Idu22oQ58o603RAT0UQ4K2Oo4OqBVRQW52S8hT9EqmNgMHqyvkESRViXszR0v+hgeSKTB/hvr2DcXFYMxJwiRljHcf/2G4=
In-reply-to: <20080427234056.GA108924158@sgi.com>
References: <200804261651.02078.vda.linux@googlemail.com> <20080427234056.GA108924158@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: KMail/1.8.2
On Monday 28 April 2008 01:40, David Chinner wrote:
> On Sat, Apr 26, 2008 at 04:51:02PM +0200, Denys Vlasenko wrote:
> > Hi David,
> > 
> > This patch reduces xfs_bmap_btalloc() stack usage by 50 bytes
> > by moving part of its body into a helper function.
> 
> Can you please attach your patches inline, Denys (see
> Documentation/SubmittingPatches)?

I can, but Kmail is notorious for mangling them :(

Is it ok if I will paste them inline AND attach them too,
so that you get guaranteed-nonmangled one in attachment?

> I have a set of patches that introduces new functionality into the
> allocator (dynamic allocation policies) that reduces
> xfs_bmap_btalloc() function by 36 bytes (just by chance, I didn't
> design it for this purpose). It breaks it down on functional
> boundaries like Christoph's patch. I'm going to revist that patch
> w.r.t both these patches and see what falls out the bottom...

Nice to know that.

Can you point me to svn/CVS/git/whatever which holds latest xfs
devel tree?
--
vda


<Prev in Thread] Current Thread [Next in Thread>