| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc() |
| From: | Andi Kleen <andi@xxxxxxxxxxxxxx> |
| Date: | Sat, 26 Apr 2008 22:26:30 +0200 |
| Cc: | Andi Kleen <andi@xxxxxxxxxxxxxx>, Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>, David Chinner <dgc@xxxxxxx>, xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20080426200701.GA10883@infradead.org> |
| References: | <200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@googlemail.com> <87iqy4wfjq.fsf@basil.nowhere.org> <20080426200701.GA10883@infradead.org> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Sat, Apr 26, 2008 at 04:07:01PM -0400, Christoph Hellwig wrote: > On Sat, Apr 26, 2008 at 10:02:17PM +0200, Andi Kleen wrote: > > Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx> writes: > > > > > > Compile tested only. > > > > You should mark the helper noinline just to prevent gcc from possibly > > inlining it. Even if it doesn't with your current compiler inline heuristics > > vary widely between compiler versions. > > STATIC as defined by xfs already does this.. Weird. Unexpected. Different from everyone else. Is this some exercise in obfuscation? But ok. -Andi |
| Previous by Date: | [PATCH] merge xfs_mntupdate into xfs_fs_remount, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig |
| Next by Thread: | Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |