xfs
[Top] [All Lists]

PARTIAL TAKE 980084 - Clean up xfs_alloc_search_busy() return values.

To: sgi.bugs.xfs@xxxxxxxxxxxx
Subject: PARTIAL TAKE 980084 - Clean up xfs_alloc_search_busy() return values.
From: dgc@xxxxxxx (David Chinner)
Date: Wed, 9 Apr 2008 17:16:13 +1000 (EST)
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
Clean up xfs_alloc_search_busy() return values.

xfs_alloc_search_busy() returns an index into the busy
array if the extent was found in the array. This is never checked,
and the xfs_alloc_search_busy() does a log force to prevent
reuse of the extent before the free transaction hits the disk.
Hence the return value is useless. Declare the function void
and remove the slot number from the tracing as well.


Date:  Wed Apr  9 17:15:51 AEST 2008
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  xaiki@xxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:30796a
fs/xfs/xfs_alloc.c - 1.191 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_alloc.c.diff?r1=text&tr1=1.191&r2=text&tr2=1.190&f=h
        - Clean up xfs_alloc_search_busy() return values.



<Prev in Thread] Current Thread [Next in Thread>
  • PARTIAL TAKE 980084 - Clean up xfs_alloc_search_busy() return values., David Chinner <=