| To: | David Chinner <dgc@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/7] XFS: Name operation vector for hash and compare |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 3 Apr 2008 18:51:20 -0400 |
| Cc: | Barry Naujok <bnaujok@xxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20080403012912.GO103491721@sgi.com> |
| References: | <20080402062508.017738664@chook.melbourne.sgi.com> <20080402062707.797672682@chook.melbourne.sgi.com> <20080403012912.GO103491721@sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Thu, Apr 03, 2008 at 11:29:12AM +1000, David Chinner wrote: > > +#define xfs_dir_hashname(dp, n, l) \ > > + ((dp)->i_mount->m_dirnameops->hashname((n), (l))) > > + > > +#define xfs_dir_compname(dp, n1, l1, n2, l2) \ > > + ((dp)->i_mount->m_dirnameops->compname((n1), (l1), (n2), (l2))) > > + > > Static inline functions, please. Or kill them completely. I find the common Linux style that jut opencodes method invocations a lot more readable. |
| Previous by Date: | Re: [PATCH 5/7] XFS: Unicode case-insensitive lookup implementation, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/7] XFS: ASCII case-insensitive support, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 1/7] XFS: Name operation vector for hash and compare, Barry Naujok |
| Next by Thread: | Re: [PATCH 0/7] XFS: case-insensitive lookup and Unicode support, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |