xfs
[Top] [All Lists]

PARTIAL TAKE 976035 - cleanup xfs_vn_mknod

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: PARTIAL TAKE 976035 - cleanup xfs_vn_mknod
From: lachlan@xxxxxxx (Lachlan McIlroy)
Date: Fri, 22 Feb 2008 13:07:34 +1100 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
cleanup xfs_vn_mknod

 - use proper goto based unwinding instead of the current mess of
   multiple conditionals
 - rename ip to inode because that's the normal convention for Linux
   inodes while ip is the convention for xfs_inodes
 - remove unlikely checks for the default_acl - branches marked unlikely
   might lead to extreme branch bredictor slowdons if taken and for some
   workloads a default acl is quite common
 - properly indent the switch statements
 - remove xfs_has_fs_struct as nfsd has a fs_struct in any semi-recent
   kernel


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Date:  Fri Feb 22 13:06:33 AEDT 2008
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-hch
Inspected by:  lachlan
Author:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:30529a
fs/xfs/linux-2.6/xfs_iops.c - 1.276 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_iops.c.diff?r1=text&tr1=1.276&r2=text&tr2=1.275&f=h
        - cleanup xfs_vn_mknod




<Prev in Thread] Current Thread [Next in Thread>
  • PARTIAL TAKE 976035 - cleanup xfs_vn_mknod, Lachlan McIlroy <=