| To: | Mark Goodwin <markgw@xxxxxxx> |
|---|---|
| Subject: | Re: [patch] Don't change ctime in truncate is size does not change |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Tue, 19 Feb 2008 12:55:20 +1100 |
| Cc: | David Chinner <dgc@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <47BA16CC.7040700@sgi.com> |
| References: | <20080218233251.GV155407@sgi.com> <47BA16CC.7040700@sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Tue, Feb 19, 2008 at 10:37:48AM +1100, Mark Goodwin wrote: > Did we ever discover what was behind the comment: > "Have to do this even if the file's size doesn't change" It was put there when the patch was checked in - I can only assume that it was done this way because the old test script that was being run didn't discriminate between the truncate and truncate differences. Basically, both the code and the comment are wrong and needed to be fixed.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Differences in mkfs.xfs and xfs_info output., David Chinner |
|---|---|
| Next by Date: | Re: Differences in mkfs.xfs and xfs_info output., Jan Derfinak |
| Previous by Thread: | Re: [patch] Don't change ctime in truncate is size does not change, Mark Goodwin |
| Next by Thread: | Re: [patch] Don't change ctime in truncate is size does not change, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |