| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: PARTIAL TAKE 971186 - Fix regression due to refcache removal |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Thu, 14 Feb 2008 13:59:36 +1100 |
| Cc: | sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <20080214011850.8F03858C4C11@chook.melbourne.sgi.com> |
| References: | <20080214011850.8F03858C4C11@chook.melbourne.sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Thu, Feb 14, 2008 at 12:18:50PM +1100, Lachlan McIlroy wrote: > Fix regression due to refcache removal Can we please use more descriptive check-in messages? Remember, the description is what ends up in the git commit log and so needs to include a summary of the problem and the fix that was made. That way the it's easy see what changes were made when read the git log without needed to look at diffs. IOWs, the description should read: "Fix a regression due to the refcache removal. Some code in xfs_rwunlock() was accidentally removed when removing the refcache. This results in inodes not being properly unlocked and causes system hangs. Fixed by reinstating the missing code." Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | PARTIAL TAKE 971186 - Fix regression due to refcache removal, Lachlan McIlroy |
|---|---|
| Next by Date: | [PATCH] fix mount option pasing to make inode cluster deletion default (again), Eric Sandeen |
| Previous by Thread: | PARTIAL TAKE 971186 - Fix regression due to refcache removal, Lachlan McIlroy |
| Next by Thread: | [PATCH] fix mount option pasing to make inode cluster deletion default (again), Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |