| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH V2] make inode reclaim synchronise with xfs_iflush_done() |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Thu, 7 Feb 2008 18:20:16 +1100 |
| Cc: | xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <47AA86E5.5030804@sgi.com> |
| References: | <47AA86E5.5030804@sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Thu, Feb 07, 2008 at 03:19:49PM +1100, Lachlan McIlroy wrote: > On a forced shutdown, xfs_finish_reclaim() will skip flushing the inode. > If the inode flush lock is not already held and there is an outstanding > xfs_iflush_done() then we might free the inode prematurely. By acquiring > and releasing the flush lock we will synchronise with xfs_iflush_done(). Looks fine. Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: unpushed 4-month-old mods?, Christoph Hellwig |
|---|---|
| Next by Date: | [PATCH] kill t_sema member of struct xfs_trans, Christoph Hellwig |
| Previous by Thread: | [PATCH V2] make inode reclaim synchronise with xfs_iflush_done(), Lachlan McIlroy |
| Next by Thread: | [PATCH] kill t_sema member of struct xfs_trans, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |