Re: [PATCH 1/1] XFS: Replace custom AIL linked-list code with struct list_head

["Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>]

On Mon, Feb 04, 2008 at 03:52:30PM -0500, Christoph Hellwig wrote:
> On Mon, Feb 04, 2008 at 01:28:08AM -0500, Josef 'Jeff' Sipek wrote:
> > Signed-off-by: Josef 'Jeff' Sipek <jeffpc@xxxxxxxxxxxxxx>
> > ---
> > This patch assumes you already have Dave Chinner's patch for
> > xfsidbg_xlogitem and xfsidbg_xaildump is needed.
> > 
> > Changes since V1:
> > 
> > - Pass around a pointer to the AIL, not the struct list_head
> > - Make sure things compile & run with CONFIG_XFS_DEBUG
> 
> Does it work with XFS_TRANS_DEBUG defined aswell?
 
With XFS_TRANS_DEBUG on, other places in XFS don't compile, but this does
and works (xfsqa ran fine).

> > -   lip = xfs_ail_min(&(mp->m_ail.xa_ail));
> > +   lip = xfs_ail_min(&(mp->m_ail));
> 
> Care to remove these useless braces in all the places you touch while you're 
> at it?

Will do.

Josef 'Jeff' Sipek.

-- 
The box said "Windows XP or better required". So I installed Linux.